MF1 Test Fixes#234
Merged
barnabywalters merged 9 commits intomicroformats:mainfrom Jun 28, 2022
cjw6k:mf1-test-fixes
Merged
Conversation
Collaborator
|
Looks good to me, thanks a lot for this contribution! |
This was referenced Jul 8, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 10 / 27 failing MF1 tests.
I put this together while checking into how the parser worked internally. I don't have a use-case for better mf1 parsing with php-mf2 and wasn't attentive to how these changes may impact current users. I see failing tests, I make them pass. 😸